Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dang/fix sdk46 test #72

Merged
merged 5 commits into from
Jul 19, 2022
Merged

Dang/fix sdk46 test #72

merged 5 commits into from
Jul 19, 2022

Conversation

GNaD13
Copy link

@GNaD13 GNaD13 commented Jul 19, 2022

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

nghuyenthevinh2000
nghuyenthevinh2000 reviewed Jul 19, 2022
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
@nghuyenthevinh2000 nghuyenthevinh2000 merged commit 0b96211 into sdk-46 Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghuyenthevinh2000 nghuyenthevinh2000 nghuyenthevinh2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@GNaD13 @nghuyenthevinh2000