Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[84] Exclude incomplete games from stats #92

Merged
merged 1 commit into from
Feb 13, 2019
Merged

[84] Exclude incomplete games from stats #92

merged 1 commit into from
Feb 13, 2019

Conversation

notmarkmiranda
Copy link
Owner

Closes #84

@notmarkmiranda notmarkmiranda force-pushed the 84-exclude-incomplete-games-from-stats branch from e565a12 to 9a94d51 Compare February 13, 2019 20:48
@notmarkmiranda notmarkmiranda merged commit 65a10dc into master Feb 13, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 266

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.8%) to 95.029%
Files with Coverage Reduction New Missed Lines %
app/models/league.rb 4 87.04%
app/models/player.rb 8 84.91%
Totals Coverage Status
Change from base Build 262: -1.8%
Covered Lines: 650
Relevant Lines: 684
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 264

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.8%) to 95.029%
Files with Coverage Reduction New Missed Lines %
app/models/league.rb 4 87.04%
app/models/player.rb 8 84.91%
Totals Coverage Status
Change from base Build 262: -1.8%
Covered Lines: 650
Relevant Lines: 684
💛 - Coveralls

notmarkmiranda added a commit that referenced this pull request Feb 22, 2019
@notmarkmiranda
Merge pull request #92 from notmarkmiranda/84-exclude-incomplete-game…
266b48e 
…s-from-stats

[84] Exclude incomplete games from stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@notmarkmiranda @coveralls