notation: remove extraneous disambiguators when decoding (L)AR #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting to draft since this causes bugs with parsing things like: |
sumnerevans
force-pushed
the
remove-extraneous-disambiguators
branch
from
c5b7002
to
8b353c6
Compare
sumnerevans
force-pushed
the
remove-extraneous-disambiguators
branch
from
8b353c6
to
b230606
Compare
|
@notnil I cleaned up that PR and I think it's ready for review now. I added a test for the case that I described in the last comment. |
|
On my computer this slows the parser down from: to likely due to regex. I think this is acceptable considering this is a bug that has come up multiple times and it makes the code easier to reason able. Thanks for creating the PR @sumnerevans . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82
This PR adds support for removing unnecessary move disambiguators when decoding a move.
It also makes some refactors to use
regexp, and use the same decode logic for long algebraic notation and algebraic notation.