Make APNS.java final

[matzew]

Since the class has only one private CTOR, you can't extend it anyways, so let's make it final

[froh42]

This is a fair enough change, unfortunatley notnoop seems to be missing in action for the last year.

(Merged into https://github.com/froh42/java-apns/commit/40b3a675be54cadae18d0c842ec0e9658b75cae7)

[matzew]

Thanks - yeah, may concern is a bit in there.

So,... forking is the way to deal with this !?

[froh42]

As the project I'm working in uses the library I forked it to integrate all the patches and other forks (feels like http://xkcd.com/927/ ). There were quite a number of useful fixes done by 3rd parties. I'm trying to keep on top of other changes just out of self-interest, and hope for the day where notnoop returns ;-)

Am 05.02.2013 um 16:39 schrieb Matthias Wessendorf notifications@github.com:

Thanks - yeah, may concern is a bit in there.

So,... forking is the way to deal with this !?

—
Reply to this email directly or view it on GitHub.

[matzew]

@froh42 I saw that @swankjesse is also using a fork (for square) of this project.

I am wondering, if all the work on the different forks could be 'unified' and if we could ensure we have releases in the future.

Looks like @notnoop is pretty quite since a few month

[froh42]

I was already in contact with square exactly because of that issue. My fork contains all of square's changes and they were considering switching to a unified fork next time they touch APNS.

I'm just not sure I want to be the maintainer, for the long run. ;-)

However currently I'm finding out what to do to push a binary of my fork to maven central to make it available for my customer's and other projects.

Am 12.02.2013 um 13:25 schrieb Matthias Wessendorf notifications@github.com:

@froh42 I saw that @swankjesse is also using a fork (for square) of this project.

I am wondering, if all the work on the different forks could be 'unified' and if we could ensure we have releases in the future.

Looks like @notnoop is pretty quite since a few month

—
Reply to this email directly or view it on GitHub.

[matzew]

@froh42 yeah - maintained src + getting releases out to maven central is my concerns. Let's see if @swankjesse has something to add.

I'd be very happy if a 'unified' fork could be created by us

[swankjesse]

Yeah, we're going to switch to @froh42's fork and delete our own. Is this a good time to make that switch?

[matzew]

that's a perfect timing. One question, @swankjesse: Does @froh42's fork contain all the Square related patches/work?

One suggestion: Should a new group/artifact ID be introduced? To avoid confusion, with the original version of the software ?

[qmx]

@swankjesse @froh42 awesome!
@matzew I think changing the maven GAV is a good thing to do - and I'm sure we can help to maintain it whether it goes under square or aerogear :)

[froh42]

I've already changed the group ID in the froh42 fork to "de.et42" and applied for write access to the sonatype maven repo. I have to find out how to correctly gpg-sign the build result (that's where I got stuck on the last try last week ... it's the first time I publish an artifact).

I have some time to try again at the beginning of next week.

Regards
Froh

Am 12.02.2013 um 15:14 schrieb Matthias Wessendorf notifications@github.com:

that's a perfect timing. One question, @swankjesse: Does @froh42's fork contain all the Square related patches/work?

One suggestion: Should a new group/artifact ID be introduced? To avoid confusion, with the original version of the software ?

—
Reply to this email directly or view it on GitHub.

[swankjesse]

Thanks @froh42. If you'd like another collaborator, I'm jessewilson on Maven Central and have some experience uploading artifacts there.

[froh42]

I've just added you guys as members to the (new) java-apns team. You didn't run away fast enough ;-)

[froh42]

It is good time to create a unified fork since there even is new work on java-apns. I just saw @mzachar forking my branch and building new stuff.

[mzachar]

That would be great to have unified fork published to maven central. I did check on all the forks and I though that @froh42 fork was the new unified one.

[joekarl]

Definitely would be good to get an "official" up to date fork that people searching for up to date apns libs can point to.

@froh42 I'm down for being a collaborator as well.

[matzew]

Awesome feedback, so far!

@froh42 was kindly creating a new repo already:
https://github.com/java-apns/java-apns

[joekarl]

Sticking with the de.et42 group id for the time being I suppose? Or should we go with a more generic id for future proofing? (ie future forks, transfer of maintenance)

[notnoop]

Greetings everyone,

Thank you all for taking the effort and maintaining the project. Last year
has been a very busy year for me (for various reasons) and I would love to
get back to the things.

I would love to contribute as well and correct the mess that I left behind.
The more immediate actionable items:

Github project: As suggested, it'll be great to unify the top three forks
(mine, square's and @froh42). I can pull the changes into
notnoop/java-apns and give admin bits to @froh42. I'm open to make it
point to java-apns/java-apns if github allows that. My initial take is
that it might be better to keep notnoop/java-apns primarily for SEO
purposes, if github doesn't support 30X redirects.

Maven Central: I noticed that @froh42 was recently granted Maven access as
well. I can push a new version to Maven Central tomorrow. We can
determine the future of next versions later.

Google Groups: I can also start giving admin bits out as needed!

My basic message is that I'm back :); but I also want ensure that the
projects can survive if I ever go MIA again, and I would love to be
supporting you guys as needed as you are probably more familiar with the
issues than me :P.

Regards,

• Mahmood

On Wed, Feb 13, 2013 at 1:16 AM, Karl Kirch notifications@github.comwrote:

Sticking with the de.et42 group id for the time being I suppose? Or should
we go with a more generic id for future proofing? (ie future forks,
transfer of maintenance)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/83#issuecomment-13443784.

[froh42]

Hello Mahmood,

welcome back! This is really great news! 

Best regards,
Froh

Am 13.02.2013 um 08:05 schrieb Mahmood Ali notifications@github.com:

Greetings everyone,

Thank you all for taking the effort and maintaining the project. Last year
has been a very busy year for me (for various reasons) and I would love to
get back to the things.

I would love to contribute as well and correct the mess that I left behind.
The more immediate actionable items:

Github project: As suggested, it'll be great to unify the top three forks
(mine, square's and @froh42). I can pull the changes into
notnoop/java-apns and give admin bits to @froh42. I'm open to make it
point to java-apns/java-apns if github allows that. My initial take is
that it might be better to keep notnoop/java-apns primarily for SEO
purposes, if github doesn't support 30X redirects.

Maven Central: I noticed that @froh42 was recently granted Maven access as
well. I can push a new version to Maven Central tomorrow. We can
determine the future of next versions later.

Google Groups: I can also start giving admin bits out as needed!

My basic message is that I'm back :); but I also want ensure that the
projects can survive if I ever go MIA again, and I would love to be
supporting you guys as needed as you are probably more familiar with the
issues than me :P.

Regards,

• Mahmood

On Wed, Feb 13, 2013 at 1:16 AM, Karl Kirch notifications@github.comwrote:

Sticking with the de.et42 group id for the time being I suppose? Or should
we go with a more generic id for future proofing? (ie future forks,
transfer of maintenance)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/83#issuecomment-13443784.

—
Reply to this email directly or view it on GitHub.

[matzew]

Hello Mahmood!

welcome back!!!

[swankjesse]

Yay!

[joekarl]

Glad to see you back!

On Feb 13, 2013, at 6:05 AM, Jesse Wilson notifications@github.com wrote:

Yay!

—
Reply to this email directly or view it on GitHub.