Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U+0600 U+0601 U+0602 U+0603 overlap the preceding letters in NotoNaskhArabic and NotoNaskhArabicUI #21

Closed
nizarsq opened this issue Oct 8, 2020 · 5 comments

Comments

@nizarsq
Copy link

nizarsq commented Oct 8, 2020

In NotoNaskhArabic and NotoNaskhArabicUI U+0600 U+0601 U+0602 U+0603 overlap the preceding letters. Look like there is zero width for those codepoints

Issue found in:

NotoNaskhArabic Version 2.000
https://github.com/googlefonts/noto-fonts/tree/master/unhinted/ttf/NotoNaskhArabic/NotoNaskhArabic-Regular.ttf
NotoNaskhArabicUI Version 2.000
https://github.com/googlefonts/noto-fonts/tree/master/unhinted/ttf/NotoNaskhArabicUI/NotoNaskhArabicUI-Regular.ttf

Characters data used in the test:
في ؀ في في ؁ في في ؂ في في ؃ في

Screenshot:
Screen Shot 2020-10-08 at 1 27 28 PM

@nizarsq
Copy link
Author

nizarsq commented Nov 26, 2020

This issue still need work NotoNaskhArabic and NotoNaskhArabicUI
Screenshot_20201126-003217_Chrome

@nizarsq nizarsq assigned nizarsq and unassigned marekjez86 Nov 26, 2020
@nizarsq nizarsq changed the title U+0600 U+0601 U+0602 U+0603 overlap the preceding letters IN NotoNaskhArabic and NotoNaskhArabicUI U+0600 U+0601 U+0602 U+0603 overlap the preceding letters in NotoNaskhArabic and NotoNaskhArabicUI Dec 27, 2020
@nizarsq
Copy link
Author

nizarsq commented Jun 12, 2021

@marekjez86 for opinion

@khaledhosny
Copy link
Contributor

The symbols seem to have negative right side bearing on the assumption that are always used in combination of digits. This is probably wrong, and they should be given positive side bearings and combine only with digits using GPOS positioning. Doing the later is trickey though, since HarfBuzz and non-HarfBuzz engines behave differently;y due to a long standing HarfBuzz issue: harfbuzz/harfbuzz#501

@marekjez86
Copy link

marekjez86 commented Jun 19, 2021

@nizarsq : I think we should wait until harfbuzz is fixed, but I don't know what's worse: (1) negative right side bearing [as it is right now] or (2) change it to positive side bearings [but don't handle GPOS positioning until harfbuzz is fixed] ... I'm leaning toward not-doing anything until some later date

@simoncozens simoncozens transferred this issue from notofonts/noto-fonts Jun 20, 2022
@simoncozens
Copy link
Contributor

This is kind of a duplicate of #34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants