Add anchor to space and thinspace glyphs #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are often used as bases for standalone marks, and it seems without anchors Chrome will badly position the marks on them (I think it might be splitting the text at the space glyph and partially shaping it). For example, the word فَٱدَّ ٰرَءٖۡتُمۡ has the small alef above mispositioned in Chrome with Noto Sans Arabic. FontBakery also complains that we are not attaching marks to the space, and this change should fix it as well.
No base glyph has it.
These anchors should be positioned like marks not dots (this distinction is made e.g. in fehDotless-ar where dots are place below the head and regular marks are centered).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are often used as bases for standalone marks, and it seems without anchors Chrome will badly position the marks on them (I think it might be splitting the text at the space glyph and partially shaping it).
For example, the word فَٱدَّ ٰرَءٖۡتُمۡ has the small alef above mispositioned in Chrome with Noto Sans Arabic.
FontBakery also complains that we are not attaching marks to the space, and this change should fix it as well.