Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Half-implemented variant Tifinagh glyphs at inappropriate code points #8

Open
dscorbett opened this issue Apr 11, 2020 · 8 comments
Open

Comments

@dscorbett
Copy link

Font

NotoSansTifinaghAPT-Regular.otf
NotoSansTifinaghAdrar-Regular.otf
NotoSansTifinaghAgrawImazighen-Regular.otf
NotoSansTifinaghAhaggar-Regular.otf
NotoSansTifinaghAir-Regular.otf
NotoSansTifinaghAzawagh-Regular.otf
NotoSansTifinaghGhat-Regular.otf
NotoSansTifinaghHawad-Regular.otf
NotoSansTifinaghRhissaIxa-Regular.otf
NotoSansTifinaghSIL-Regular.otf
NotoSansTifinaghTawellemmet-Regular.otf

Where the font came from, and when

Site: https://github.com/googlefonts/noto-fonts/blob/115d38430d957d38307457c036302b7bdbe0bbc4/phaseIII_only/unhinted/otf/NotoSansTifinagh/NotoSansTifinaghAPT-Regular.otf
Site: https://github.com/googlefonts/noto-fonts/blob/115d38430d957d38307457c036302b7bdbe0bbc4/phaseIII_only/unhinted/otf/NotoSansTifinagh/NotoSansTifinaghAdrar-Regular.otf
Site: https://github.com/googlefonts/noto-fonts/blob/115d38430d957d38307457c036302b7bdbe0bbc4/phaseIII_only/unhinted/otf/NotoSansTifinagh/NotoSansTifinaghAgrawImazighen-Regular.otf
Site: https://github.com/googlefonts/noto-fonts/blob/115d38430d957d38307457c036302b7bdbe0bbc4/phaseIII_only/unhinted/otf/NotoSansTifinagh/NotoSansTifinaghAhaggar-Regular.otf
Site: https://github.com/googlefonts/noto-fonts/blob/115d38430d957d38307457c036302b7bdbe0bbc4/phaseIII_only/unhinted/otf/NotoSansTifinagh/NotoSansTifinaghAir-Regular.otf
Site: https://github.com/googlefonts/noto-fonts/blob/115d38430d957d38307457c036302b7bdbe0bbc4/phaseIII_only/unhinted/otf/NotoSansTifinagh/NotoSansTifinaghAzawagh-Regular.otf
Site: https://github.com/googlefonts/noto-fonts/blob/115d38430d957d38307457c036302b7bdbe0bbc4/phaseIII_only/unhinted/otf/NotoSansTifinagh/NotoSansTifinaghGhat-Regular.otf
Site: https://github.com/googlefonts/noto-fonts/blob/115d38430d957d38307457c036302b7bdbe0bbc4/phaseIII_only/unhinted/otf/NotoSansTifinagh/NotoSansTifinaghHawad-Regular.otf
Site: https://github.com/googlefonts/noto-fonts/blob/115d38430d957d38307457c036302b7bdbe0bbc4/phaseIII_only/unhinted/otf/NotoSansTifinagh/NotoSansTifinaghRhissaIxa-Regular.otf
Site: https://github.com/googlefonts/noto-fonts/blob/115d38430d957d38307457c036302b7bdbe0bbc4/phaseIII_only/unhinted/otf/NotoSansTifinagh/NotoSansTifinaghSIL-Regular.otf
Site: https://github.com/googlefonts/noto-fonts/blob/115d38430d957d38307457c036302b7bdbe0bbc4/phaseIII_only/unhinted/otf/NotoSansTifinagh/NotoSansTifinaghTawellemmet-Regular.otf
Date: 2020-04-11

Font version

Version 2.002

Issue

All of the Noto Tifinagh fonts except Noto Sans Tifinagh itself attempt to use alternative glyphs for some characters. They only work when the direction is right-to-left.

Furthermore, some of the variant glyphs are so different from the defaults as to be different characters in Unicode’s model of Tifinagh, where unrelated glyphs with the same sound get different code points (e.g. U+2D4A YAZH vs. U+2D4B AHAGGAR YAZH vs. U+2D4C TUAREG YAZH) and a single code point can represent different sounds that share a single glyph (e.g. U+2D40 YAH = Tuareg yab). If a certain glyph isn’t a glyph variant of any already in Unicode’s code chart, it should be proposed to Unicode as a new character.

Character data

This is just an example. Many characters are affected.


U+2D3B TIFINAGH LETTER YEY

Screenshots

These screenshots are from Noto Sans Tifinagh APT. The same sort of problem appears in the other fonts for other code points.

LTR:
ⴻ
RTL:
‮ⴻ‬

@digitalheir
Copy link

@simoncozens
Copy link
Contributor

I think this is fixed now?

simon@Simons-MacBook-Air ~/work/noto/tifinagh .*$ hb-shape master_ttf/NotoSansTifinagh-Regular.ttf 'ⴻ' --direction=ltr
[yey-tifi=0+560]
simon@Simons-MacBook-Air ~/work/noto/tifinagh .*$ hb-shape master_ttf/NotoSansTifinagh-Regular.ttf 'ⴻ' --direction=rtl
[yey-tifi=0+560]

@dscorbett
Copy link
Author

Is it fixed in NotoSansTifinaghAPT-Regular.ttf?

@simoncozens
Copy link
Contributor

Ah, no. I didn't quite see the "except Noto Sans Tifinagh itself".

@simoncozens simoncozens reopened this Mar 10, 2023
@simoncozens
Copy link
Contributor

There is a much bigger problem here. The glyph renaming, to produce the variant glyphs, has never really worked in the fontmake pipeline, only in Glyphs exports. This is because I only actually implemented the "Rename Glyphs" custom parameter in glyphsLib last November. Additionally, the glyph renaming rules are completely mad, and refer to glyphs that we don't even have in the glyphset, such as:

  • (In Tewellemmet) yan_yaf_yat-tifi=yaf_yat-tifi, yaw-titi=yawBerber-tifi (clearly a typo for yaw-tifi)
  • (In Adrar) yaghh-tifi=yagAyer-tifi (presumably a typo for yaghAyer-tifi)

I've fixed the obvious problems here and now we are building variant glyphs, but I feel out of my depth here and need someone with more familiarity of the different Tifinagh variants to take a look over.

Also the fact that this has been totally broken for years and nobody seems to have noticed is slightly concerning.

@digitalheir
Copy link

digitalheir commented May 22, 2023

this has been totally broken for years and nobody seems to have noticed is slightly concerning

Perhaps it is not so strange; many Tamazight / Berber speakers cannot write, those who can mostly make do with what they have. Usually that means: transliterating to Arabic / Latin.

Capable input methods are only slowly coming along and entering conciousness.

take a look over

Does it refer specifically to commit f9d7e56 and all the name changes? Or also the appropriateness of glyph shapes per dialect / variant?

Some general things to note, at least:

  • Some names are deceptively similar (yad / yaf fricative / yadj / yaḍ / yaḍ fricative); they are easy to mix up
  • Different dialect may use the same shape for different letters
  • Glyphs may wildly differ from writer to writer within a dialect, since they have generally not been rigidly formalized with the exception of Moroccan IRCAM letters (Neo-Tifinagh).

@simoncozens
Copy link
Contributor

Or also the appropriateness of glyph shapes per dialect / variant?

Yes, this; basically, I would like some to review the current fonts, now that they are building with dialectal variants, to ensure that they are doing the right thing and showing the right glyphs for the right letters.

@abdelhaqueidali
Copy link

It seems there is still some issues with ligatures, i have created a new issue about it. Check it out here, am new to github, so i probably didn't provide enough information in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants