Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors installing on windows #36

Closed
fmiqbal opened this issue Jun 9, 2020 · 10 comments
Closed

Errors installing on windows #36

fmiqbal opened this issue Jun 9, 2020 · 10 comments
Assignees

Comments

@fmiqbal
Copy link

fmiqbal commented Jun 9, 2020

Windows and MacOS build have actually already been added to travis, just not yet to releases. Travis upload them to catbox.moe when done.

Latest Windows:
https://files.catbox.moe/wn3rbc.msi

Latest MacOs:
https://files.catbox.moe/6o27qn.zip

Originally posted by @louis-lau in #1 (comment)

I got this while installing

image

log1.log
log2.log

@notpushkin
Copy link
Owner

Thanks for reporting this! Will take a more thorough look when I can. On a glance, WiseLibs/better-sqlite3#227 might be related.

@bliet
Copy link

bliet commented Dec 17, 2020

Same bug in 1.7.8. Any plans to fix this?

@exprez135
Copy link
Collaborator

Same bug in 1.7.8. Any plans to fix this?

Yes! This is the next thing on my TODO list. I need to get familiar with the problem and investigate thoroughly. As soon as there's a fix we'll make sure to get it out. Sorry for the trouble.
If anyone has any ideas, please let me know!

@exprez135 exprez135 self-assigned this Dec 17, 2020
@exprez135
Copy link
Collaborator

Have a lead, and have a build which works on my end. If anyone can test: https://ci.appveyor.com/api/buildjobs/26ncloqje2udqifd/artifacts/MailspringSetup.exe

It appears that Travis is not properly rebuilding some modules which require native dependencies. AppVeyor does do this. If I can't get Travis to work properly we can hook AppVeyor to the repository and use Windows builds from there.

@louis-lau
Copy link

I initially submitted a working PR which used appveyor. But then someone moved it to Travis. So we could just revert that if it solves this issue.

@exprez135
Copy link
Collaborator

That would be me 🤦
I think I've actually gotten Travis to work now. It's all a caching problem. I'm going to test the new build and update the release with new files tonight.

@exprez135
Copy link
Collaborator

Update: I was wrong. Travis rebuilt everything but I encountered the same error. I've just pushed .appveyor.yml back into the repo (thank you @louis-lau!).

@notpushkin is it possible for us to set up an AppVeyor project for the repo?

I've just updated the release files with functioning Windows 1.7.8 builds.

@notpushkin
Copy link
Owner

@exprez135 IIRC AppVeyor didn't work for me (it did work for @louis-lau though, so that's weird). I'll give it one more try tonight and let you know if it works!

@notpushkin
Copy link
Owner

Looks like we're good to go!

Windows build status

@exprez135
Copy link
Collaborator

Awesome! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants