autobuild updates #231
Merged
autobuild updates #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmonz
requested review from
DerDakon,
josuah,
leahneukirchen and
mbhangui
as code owners
This was referenced Jan 13, 2022
DerDakon
requested changes
Jan 13, 2022
- Catch up to vmactions/solaris-vm 0.0.5 (and pin to a macOS host version that has `vboxmanage`) - Explicitly build 64-bit to avoid mixed-bitness linker errors - Build a recent check from source, since there's no package new enough
On at least Solaris 11's make(1), "NROFF?=nroff" means the suffix rules for generating preformatted manpages somehow get an empty value for NROFF. Setting "NROFF=nroff" fixes this behavior. This change means "NROFF=true make man" no longer overrides the value of NROFF, but that's okay: "make NROFF=true man" still does. Our own autobuilds already do the latter. Fixes: 95f86da
schmonz
force-pushed
the
schmonz-autobuild-updates
branch
from
4b0ba82 to
6c12e8a
Compare
DerDakon
approved these changes
Jan 15, 2022
mbhangui
approved these changes
Jan 15, 2022
leahneukirchen
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the broken Solaris builds, including (I believe) solutions to #203 and #209.
As a prerequisite to #224, we need a newer libcheck on Solaris and Ubuntu. For the latter, we can get away with installing a binary package from a newer Ubuntu; for the former, we build from source. It might be worth following up this PR with one that caches the built libcheck, as the Solaris builds are already very slow.