qmail-qstat: simplify the code

[DerDakon]

See the commits for a detailed description, but boils down to:

• avoid needless dependencies in Makefile
• use find -type f to just count files and avoid much complication in the script

[DerDakon]

@mbhangui your Indimail uses big-todo IIRC, could you check if this works properly there?

[mbhangui]

@mbhangui your Indimail uses big-todo IIRC, could you check if this works properly there?

This works for big-todo because it uses find. The earlier script didn't work because it expected all files to be in queue/todo directory.

[josuah]

LGTM, seal of approval

Maybe if someone does something funky with symlinks, then an extra -L flag to find could be useful though?

[josuah]

The wc -w to wc -l make sense, find produces one result per line.
It is all based upon the absence of spaces in file names here anyway.

Maybe another case where -type f was not widely available.

[DerDakon]

I expect someone that does such special things to the queue to be able to hack this script as well.

[schmonz]

find(1) is always a portability risk, but the way it's used here feels likely to work on every platform we could possibly care about, and the way this would break (if we're wrong about that) would be tolerable. Breaking this portion of the big-todo patch would usually be counter to our project goals, but I consider this an excellent exception: we're breaking it because we've made it unnecessary, and the rest of the patch is unaffected. And of course removing unused dependencies is a small but permanently cost-cutting victory.