Correctness: Reject non-numeral netstring lengths in qmtpd and qmqpd #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janicez
requested review from
DerDakon,
josuah,
leahneukirchen,
mbhangui and
schmonz
as code owners
mbhangui
approved these changes
Oct 20, 2022
leahneukirchen
approved these changes
Oct 20, 2022
DerDakon
requested changes
Oct 20, 2022
…fted length to qmail-qmqpd or qmtpd and it would just work (as long as there was no integer wraparound) based off the ASCII value. This commit: * includes a check in the netstring parsing code in qmail-qmtpd and qmail-qmqpd that balks the program if the length field of a netstring is not a numeral, and * updates CHANGES.md to include the note about the change in netstring behavior
DerDakon
approved these changes
Oct 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed on IRC between myself and a few other people back in September, and I finally got around to doing it recently. Logs can be added to the ticket upon request.