remove shar target from Makefile. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also remove FILES. Noone needs it: if you want go do a release, use |
|
Have you ever tried running it? It has never worked, because it depends e.g. on BIN.setup that has never existed. Kill it with fire. |
alanpost
force-pushed
the
pr-XX-remove-shar-target
branch
from
f259282
to
10609d2
Compare
alanpost
force-pushed
the
pr-XX-remove-shar-target
branch
from
10609d2
to
c68f749
Compare
The shar target restates the contents of FILES as dependencies on the shar target, a shell archive. Shell archives are no longer used for distributing software. While the command could be updated to use an alternative distribution format, like tape archive (tar), that the rule must restate the contents of FILES means any modification to FILES must also be restated here, and in a way that is more likely to cause a merge conflict. Further, as this is the only place in the code that uses FILES, remove FILES. It demonstrably is not up-to-date, as it contains an entry for the nonexistent INSTALL-1.03, and git ls-files is a suitable replacement.
alanpost
force-pushed
the
pr-XX-remove-shar-target
branch
from
c68f749
to
99e9dab
Compare
Closed
|
This commit now also removes the FILES file. |
schmonz
approved these changes
Jul 19, 2019
DerDakon
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This target restates the contents of FILES as dependencies on the
shar target, a shell archive. Shell archives are no longer used
for distributing software. While the command could be updated to
use an alternative distribution format, like tape archive (tar),
that the rule must restate the contents of FILES means any
modification to FILES must also be restated here, and in a way
that is more likely to cause a merge conflict.