Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing favicon.ico #120

Open
juanfernandes opened this issue Oct 10, 2023 · 3 comments
Open

Missing favicon.ico #120

juanfernandes opened this issue Oct 10, 2023 · 3 comments

Comments

@juanfernandes
Copy link
Contributor

The network tab in devtools shows that the favicon.ico is missing. I've tried to add it, but I can't get it to work. I've tried this (https://nextjs.org/docs/app/api-reference/file-conventions/metadata/app-icons) but still can't get it to work for me.

Anyone know how to get this fixed please?

@juanfernandes
Copy link
Contributor Author

@notrab How do I make a PR to fix this? I tried pushing my branch up to the repo but it wont let me :D

@notrab
Copy link
Owner

notrab commented Oct 17, 2023

Hey @juanfernandes you'll need to "Fork" the repo, commit the changes and then open a pull request 🙌🏻

@juanfernandes
Copy link
Contributor Author

Ah ok, cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants