This repository has been archived by the owner on Jan 19, 2020. It is now read-only.
no_std float sorting
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before `num_traits::Float` was used, which does not support `no_std` because it uses a lot of math functions (`cos`, `sin`, etc.) that are not implemented in `core`. Those are however not needed for sorting floats, so we implement a minimal trait required for sorting floats inside this crate instead. The `float` feature was left in for backwards compatibility. It does not do anything, because now we can implement sorting of floats by default.
|
Your PR is approved. Also, bors should listen to you, now, and you should be able to edit issues and such. bors r+ |
Build succeeded |
|
Thanks! Note that this was a breaking change: `sort_floats` now only works
for `f32` and `f64`. I don't think anyone used it for something else,
because `num_traits::Float` is not suited for arbitrary precision floats.
If you decide to release 3.0 I would suggest to remove the `float` feature.
…On Tue, May 30, 2017, 19:30 bors[bot] ***@***.***> wrote:
Build succeeded
- continuous-integration/travis-ci/push
<https://travis-ci.org/notriddle/quickersort/builds/237610715?utm_source=github_status&utm_medium=notification>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACCtPjt-VP_CFw-I_qTSLYphlehJLkiks5r_FIwgaJpZM4NqjER>
.
|
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.