Feature: Generating private repositories #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something I was planning to do since sometime — allow generating private projects via `go-template` Up until now, projects were generated by `go-template` under the assumption that they will always be public — which, isn't always true. Private projects would end up with broken links on their README because shields.io can't reach the project! This commit is the first step in this direction Signed-off-by: notsatan <git@notsatan.me>
The README's for generated projects would now be able to handle cases where the project is private — badges would be hidden or modified based on this Signed-off-by: notsatan <git@notsatan.me>
Update the versions of Go supported Signed-off-by: notsatan <git@notsatan.me>
Apparently some upstream issue with the badges caused a badge on the homepage to break down. This commit should fix that Signed-off-by: notsatan <git@notsatan.me>
Signed-off-by: notsatan <git@notsatan.me>
notsatan
added
documentation
The pre-gen Python script had a typo in the name of a function Signed-off-by: notsatan <git@notsatan.me>
With this commit, the recent changes allowing users to use this template to generate private projects have been documented in the project README Signed-off-by: notsatan <git@notsatan.me>
Signed-off-by: notsatan <git@notsatan.me>
Signed-off-by: notsatan <git@notsatan.me>
This directly relates to #43, with this in place there is no longer a need to decide where to store stderr logs Signed-off-by: notsatan <git@notsatan.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Up until now, projects were generated by
go-templateunder the assumption that they will always be public — which, isn't always true. Private projects would end up with broken links on their README becauseshields.iocan't access the project!This feature intends to resolve this by removing/updating the links on the generated README to ensure private repositories can generate a project with this template and use it right out of box
Type of Change
Review Process
Reviewees:
Reviewers: