Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow authentication using Discourse forum #272

Closed
wants to merge 6 commits into from

Conversation

davidtaylorhq
Copy link
Contributor

No description provided.

@davidtaylorhq davidtaylorhq temporarily deployed to pyrigs-pr-272 November 2, 2016 21:03 Inactive
@davidtaylorhq davidtaylorhq temporarily deployed to pyrigs-pr-272 November 2, 2016 21:27 Inactive
@davidtaylorhq
Copy link
Contributor Author

Well, the tests fail because I disabled Django registration, so to be expected

@davidtaylorhq davidtaylorhq temporarily deployed to pyrigs-pr-272 November 2, 2016 23:51 Inactive
@davidtaylorhq davidtaylorhq temporarily deployed to pyrigs-pr-272 November 3, 2016 00:09 Inactive
@tomtom5152
Copy link
Member

Haven't checked any logic, but it all looks good. My main concern is it desperately needs tests, to the point where I almost feel the Discourse module should be a separate package that can be tested independently, then integrated into the RIGS properly. Also has the advantage of making it a standalone library that others can use.

Currently not happy for this to be merged without any tests.

@davidtaylorhq
Copy link
Contributor Author

davidtaylorhq commented Jan 23, 2017 via email

@davidtaylorhq
Copy link
Contributor Author

Closing PR until I get around to re-writing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants