-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow authentication using Discourse forum #272
Conversation
Well, the tests fail because I disabled Django registration, so to be expected |
…nked to forum account
Haven't checked any logic, but it all looks good. My main concern is it desperately needs tests, to the point where I almost feel the Discourse module should be a separate package that can be tested independently, then integrated into the RIGS properly. Also has the advantage of making it a standalone library that others can use. Currently not happy for this to be merged without any tests. |
The more I think about it the more I agree with you.
I'm also now disliking the dependency on the external social-auth library - implementing the discourse auth is pretty easy with some basic cryptography libraries (see my mediawiki plugin) so I might try and write some middleware (or whatever it should be called) to do what we need in a more simple way.
Would be nice if we can get this implemented before new members, so I'll try and get it done after my exam on Wednesday.
|
Closing PR until I get around to re-writing |
No description provided.