Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable password reset as temporary fix to vulnerability #396

Merged
merged 2 commits into from
Jan 17, 2020

Conversation

mattysmith22
Copy link
Member

in response to CVE-2019-19844

@johnathan99j johnathan99j temporarily deployed to pyrigs-pr-396 January 17, 2020 12:35 Inactive
@FreneticScribbler
Copy link
Member

FreneticScribbler commented Jan 17, 2020

Godsdamn you man. Maybe if you use a virtual environment your pep8 standard will stop being magically different to literally everyone elses...

🔨

@davidtaylorhq davidtaylorhq merged commit e0c6a56 into master Jan 17, 2020
@mattysmith22
Copy link
Member Author

@FreneticScribbler hey! I don't need no virtual environment! I always run pip3 install -r requirements.txt before developing stuff 😂

FreneticScribbler added a commit that referenced this pull request Feb 19, 2020
FreneticScribbler added a commit that referenced this pull request Mar 7, 2020
* [requires.io] dependency update

* Server starts...

Various things are broken, but it runs!

* [requires.io] dependency update

* [requires.io] dependency update

* [requires.io] dependency update

* FIX: Broken migrations

* FIX: Update auth framework

* FIX: Correct static use in templates

* FIX: Fix supplier sort

* FIX: Remaining tests

* Revert "Disable password reset as temporary fix to vulnerability (#396)"

This reverts commit e0c6a56.

# Conflicts:
#	RIGS/urls.py

* FIX: Fix broken newlining in PDFs

Introduced by a change in Django 2.1 'HTML rendered by form widgets no longer includes a closing slash on void elements, e.g. <br>. This is incompatible within XHTML, although some widgets already used aspects of HTML5 such as boolean attributes.'

* FIX: Fix some Django4 deprecation warnings

Why not...

* Refactor dependency file

Should now only include dependencies we actually use, not dependencies of dependencies and unused things

* Add newlines to the paperwork print test event

This will catch the error encountered in 79ec921

* Swap to pycodestyle rather than pep8 in Travis

And eliminate W605 errors

* Bit too heavy handed with the dep purge there...

* Whoops, helps if one installs pycodestyle...

* FIX: Re-add overridden login view

* Better fix for previous commit

* FIX: Bloody smartquotes

Co-authored-by: requires.io <support@requires.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants