Add description field to TrainingItems #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed existing field to name, removed the dummy property.
|
Nice 👌🏻 |
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good. Worth considering though. View full project report here.
PyRIGS/views.py
Outdated
| object_name = re.sub(r'[^a-zA-Z0-9 \n\.]', '', obj.name) | ||
|
|
||
| context = { | ||
| 'object': obj, | ||
| 'current_user': self.request.user, | ||
| 'object_name': object_name, | ||
| 'info_string': f"[Paperwork generated {user_str}on {time} - {obj.current_version_id}]", | ||
| 'info_string': get_info_string(self.request.user) + "- {obj.current_version_id}]", |
There was a problem hiding this comment.
Suggested change
| 'info_string': get_info_string(self.request.user) + "- {obj.current_version_id}]", | |
| 'info_string': get_info_string(self.request.user) + f"- {obj.current_version_id}]", |
If this was meant to be f-string then f prefix is missing. More info.
PyRIGS/views.py
Outdated
| class PrintListView(generic.ListView): | ||
| def get_context_data(self, *args, **kwargs): | ||
| context = super().get_context_data(*args, **kwargs) | ||
| context['current_user'] = self.request.user, |
There was a problem hiding this comment.
Suggested change
| context['current_user'] = self.request.user, | |
| context['current_user'] = self.request.user |
It looks like None should not be a tuple? The comma after the value makes it a tuple. Explained here.
training/views.py
Outdated
|
|
||
| def get_context_data(self, **kwargs): | ||
| context = super().get_context_data(**kwargs) | ||
| context['filename'] = f"TrainingItemList.pdf" |
There was a problem hiding this comment.
Suggested change
| context['filename'] = f"TrainingItemList.pdf" | |
| context['filename'] = "TrainingItemList.pdf" |
f-string is unnecessary here. This can just be a string. Read more.
FreneticScribbler
temporarily deployed
to
pyrigs-pipel-trainingit-gfjxeq
FreneticScribbler
temporarily deployed
to
pyrigs-pipel-trainingit-gfjxeq
FreneticScribbler
temporarily deployed
to
pyrigs-pipel-trainingit-gfjxeq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds the ability to export the training item list to a PDF. WIP.