Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cat-dns answers are invalid #5

Closed
colmmacc opened this issue Feb 19, 2014 · 1 comment
Closed

cat-dns answers are invalid #5

colmmacc opened this issue Feb 19, 2014 · 1 comment

Comments

@colmmacc
Copy link

cat-dns's answers don't include the original question, in violation of RFC1035. DNS answers must include the original question being asked. So the qd_count should be 1, the an_count should be 1 (since cats have just one IP address) and ar_count and ns_count should always be zero.
@colmmacc colmmacc mentioned this issue Feb 19, 2014
Closed
colmmacc pushed a commit to colmmacc/cat-dns that referenced this issue Feb 21, 2014
Make cat-dns answers valid
0dc4a0b 
Fix for notwaldorf#5, include the original question
in the DNS response generated.
@colmmacc colmmacc mentioned this issue Feb 21, 2014
Merged
@notwaldorf
Copy link
Owner

Fixed by in 918f96b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colmmacc @notwaldorf