Data: remove candidate creation fee when used to update a proposal #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prep for adding tests that need to interact with the DAO
❌ Deploy Preview for nouns-testnet failed.
|
❌ Deploy Preview for nouns-home failed.
|
eladmallel
changed the base branch from
master
to
verbs-dao-v3-fix-vote-gas-refund-blunder
davidbrai
reviewed
Nov 17, 2023
packages/nouns-contracts/contracts/governance/data/NounsDAOData.sol
Outdated
Show resolved
Hide resolved
davidbrai
reviewed
Nov 17, 2023
solimander
approved these changes
Dec 1, 2023
since we had a recent incident where a candidate with more than 10 txs was created only to fail to convert to a proposal because of the tx limit proposals have
davidbrai
changed the base branch from
verbs-dao-v3-fix-vote-gas-refund-blunder
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.