use try-with-resources in KyuubiCommands

nousot · Aug 1, 2023 · 2497069 · 2497069
1 parent a54a97f
commit 2497069
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiCommands.java b/kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiCommands.java
@@ -86,10 +86,9 @@ private boolean sourceFile(String cmd) {
   }
 
   private boolean sourceFileInternal(File sourceFile) throws IOException {
-    BufferedReader reader = null;
-    try {
-      reader = new BufferedReader(new FileReader(sourceFile));
-      String lines = null, extra;
+    try (BufferedReader reader = new BufferedReader(new FileReader(sourceFile))) {
+      String lines = null;
+      String extra;
       while ((extra = reader.readLine()) != null) {
         if (beeLine.isComment(extra)) {
           continue;
@@ -107,10 +106,6 @@ private boolean sourceFileInternal(File sourceFile) throws IOException {
           return false;
         }
       }
-    } finally {
-      if (reader != null) {
-        reader.close();
-      }
     }
     return true;
   }