rely on email_validator gem rather than obsolete validate_email gem #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Thanks for this gem. The
validate_email
gem dependency creates some conflicts in my codebase, and after looking into it I figured it could be worth using theemail_validator
gem instead as it's being actively maintained (while thevalidate_email
repository hasn't been updated since 2017).The syntax remains the same (
validates :some_email_attr, email: true
).The specs were failing at first because the Mail::Address.new(contact) line was depending on the underlying
mail
gem, so I added it explicitly as well and the specs are now passing.