Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rely on email_validator gem rather than obsolete validate_email gem #79

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

efavre
Copy link
Contributor

@efavre efavre commented Nov 24, 2022

Hello!

Thanks for this gem. The validate_email gem dependency creates some conflicts in my codebase, and after looking into it I figured it could be worth using the email_validator gem instead as it's being actively maintained (while the validate_email repository hasn't been updated since 2017).

The syntax remains the same (validates :some_email_attr, email: true).
The specs were failing at first because the Mail::Address.new(contact) line was depending on the underlying mail gem, so I added it explicitly as well and the specs are now passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants