Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: animation pause on click disabled #919

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

pgolovkin
Copy link
Collaborator

@pgolovkin pgolovkin commented Jun 29, 2023

  1. there is a warning in the log:
[1] 2023/06/29 23:45:19.042 [staging#1.0.1]-renderer [warn]  > Warning: componentWillUpdate has been renamed, and is not recommended for use. See https://reactjs.org/link/unsafe-component-lifecycles for details.
[1] 
[1] * Move data fetching code or side effects to componentDidUpdate.
[1] * Rename componentWillUpdate to UNSAFE_componentWillUpdate to suppress this warning in non-strict mode. In React 18.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.
[1] 
[1] Please update the following components: Lottie
  1. use the property isClickToPauseDisabled Click on the component will stop animation chenqingspring/react-lottie#81
  2. set autoplay to true, why was it false?

@github-actions
Copy link
Contributor

Current coverage report

Summary

Lines Statements Branches Functions
Covered: 0%

Tests which was executed

Tests Skipped Failures Errors Time
29 0 💤 0 ❌ 0 🔥 50.234s ⏱️
Coverage by files (0%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files0000 
   Animation.tsx000016–17

@github-actions
Copy link
Contributor

Jest Unit tests results

Generic badge

Duration: 282.291 seconds
Start: 2023-06-29 20:56:14.588 UTC
Finish: 2023-06-29 21:00:56.879 UTC
Duration: 282.291 seconds
Outcome: Passed | Total Tests: 361 | Passed: 360 | Failed: 0
Total Test Suites: 157
Total Tests: 361
Failed Test Suites: 0
Failed Tests: 0
Passed Test Suites: 156
Passed Tests: 360
Pending Test Suites: 1
Pending Tests: 1

@pgolovkin pgolovkin merged commit 5d92224 into dev Jun 30, 2023
4 checks passed
@tuul-wq tuul-wq deleted the fix/animation_pause_on_click_disabled branch September 6, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants