Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Original word not returned properly #11

Closed
akhilesh1311 opened this issue Sep 23, 2019 · 3 comments
Closed

Original word not returned properly #11

akhilesh1311 opened this issue Sep 23, 2019 · 3 comments

Comments

@akhilesh1311
Copy link

import urbandict
urbandict.define('anal')
[{'word': 'anal sex',
'def': 'What to avoid in prison.',
'example': 'After dropping my soap, I just let it be so as not to incite an anal rampage.'},
{'word': 'Anal unknown',
'def': 'When a crotch rocket enters the caverns of life.',
'example': 'Sarah to Doug "Will you please take the damn trash out?"Doug "Na playin Fortnite"Sarah "I'll give you Anal!"Doug "ON IT!" (Rockets off Couch)'},
{'word': 'Anal sex',
'def': 'its like having a dick in your ass',
'example': "i've never tried anal...whats it like? it's like having a dick in your ass"},
{'word': 'Anal unknown',
'def': 'Something that may happen when you are trying to lose your virginity but you are too tight and it slips in the wrong hole',
'example': "We couldn't get it in and it slipped causing me to scream wrong hole, and that's the first time I did anal"},
{'word': 'anal sex',
'def': 'Butt sex',
'example': 'Miranda is well known for her wild anal nights.'},
{'word': 'An al unknown',
'def': 'The act of stealing someone else’s mc donalds by accident, going bright red, and blaming it on ur friends who then have to go and get ur meal for you incase you get in trouble',
'example': 'Ah shit that guy is pulling an An Al'},
{'word': 'anal sex',
'def': "bend over and i'll show you.",
'example': '^ what he said ^'}]

It shouldn't return the word as 'anal unknown' or 'anal sex'.
BTW, I think unknown/sex returned is actually a tag associated with the word. Like, 'anal' word has 'sex' tag associated with in red besides it in a few definitions. Probably we can return a separate dictionary mapping for it?

novel added a commit that referenced this issue Oct 4, 2019
Apparently, for some of the words urbandictionary includes category now.
Update handlers to parse it. Now it's included in the response under
the 'category' field name.

The CLI client also prints out category (unless it's 'unknown').

Issue: #11
@novel
Copy link
Owner

novel commented Oct 4, 2019

Apparently, 'category' is a relatively new thing (or I managed to not notice it for quite some time).

I've created a branch with an initial support. Should give it a little more testing. Not sure if there could be words with multiple categories, I didn't find such...

@novel
Copy link
Owner

novel commented Oct 9, 2019

This should be fixed now.

@novel novel closed this as completed Oct 9, 2019
@akhilesh1311
Copy link
Author

Awesome! Thanks @novel .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants