Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should add CI #66

Closed
jatin69 opened this issue Oct 4, 2019 · 6 comments
Closed

should add CI #66

jatin69 opened this issue Oct 4, 2019 · 6 comments
Labels
miscellaneous Smaller odd job tasks that don't fit into a specific category/

Comments

@jatin69
Copy link
Contributor

jatin69 commented Oct 4, 2019

This project seems to have a lot of active changes and PRs. It makes sense to add a Continous Integration to the codebase to verify that PRs aren't breaking anything.
@jatin69
Copy link
Contributor Author

jatin69 commented Oct 4, 2019

If you let me know the compile statements and requirements, I'm up to add a GitHub actions CI workflow.

@RubyNova
Copy link
Member

RubyNova commented Oct 4, 2019

@tannergooding is already helping me with a public Azure DevOps pipeline (it's still a WIP, I've been a busy human being).

I'll add this to our TODOs, so we actually remember to finish this.

@RubyNova RubyNova added the miscellaneous Smaller odd job tasks that don't fit into a specific category/ label Oct 4, 2019
@tannergooding
Copy link
Member

The branch adding the basic build scripts is here: https://github.com/tannergooding/NovelRT/tree/build-scripts

Just need to finish adding the cmake/vcpkg support, etc and they should be done.

@RubyNova
Copy link
Member

RubyNova commented Oct 4, 2019

Sweet good to hear.

@RubyNova
Copy link
Member

RubyNova commented Oct 4, 2019

As per #67 the build scripts are in place. We just need to set up the appropriate things on AzDO and it's good to go.

@RubyNova
Copy link
Member

CI is now integrated. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
miscellaneous Smaller odd job tasks that don't fit into a specific category/
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tannergooding @jatin69 @RubyNova