This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Use safe-buffer to allow Node 4.0 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SafeBuffer is a polyfill that provides `.from` (among other new Buffer methods) when needed. Node 4x is still in pretty wide use and supported until 2018-04-01. I think it's worth attempting to support all of 4 especially if its not too much trouble. I named the `Buffer.from` calls `SafeBuffer.from` to satisfy the linter's no-shadow settings. That's a shadow I might allow to keep the code cleaner.
novemberborn
force-pushed
the
node-4-support
branch
2 times, most recently
from
969fa4f
to
05e6080
Compare
|
Thanks for pushing this @reconbot! |
|
And thank you for landing it =) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SafeBuffer is a polyfill that provides
.from(among other new Buffer methods) when needed. Node 4x is still in pretty wide use and supported until 2018-04-01. I think it's worth attempting to support all of 4 especially if its not too much trouble.I named the
Buffer.fromcallsSafeBuffer.fromto satisfy the linter's no-shadow settings. That's a shadow I might allow to keep the code cleaner.