Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle wrapper to 4.6 #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

friederbluemle
Copy link

@friederbluemle friederbluemle commented Apr 11, 2017

This PR also includes the build script updates that matches the new Gradle version (previous Gradle updates only update the text file gradle/wrapper/gradle-wrapper.properties without doing a full update using the gradle wrapper command). Included is also the (now standard) increase in heap space that allows dex to run in process, fixing the following warning:

Running dex as a separate process.

To run dex in process, the Gradle daemon needs a larger heap.
It currently has 1024 MB.
For faster builds, increase the maximum heap size for the Gradle daemon to at least 1536 MB.
To do this set org.gradle.jvmargs=-Xmx1536M in the project gradle.properties.
For more information see https://docs.gradle.org/current/userguide/build_environment.html

Please NO GitHub rebase/squash merges. If you'd like me to combine some or all of the commits, please let me know, and I will update my branch. Thank you.

@friederbluemle friederbluemle changed the title Update Gradle wrapper to 3.4.1 Update Gradle wrapper to 3.5 Apr 11, 2017
@smalichenko
Copy link
Contributor

smalichenko commented Apr 12, 2017

@friederbluemle Two questions:

  1. Any reasons to update gradle wrapper to 3.5? Currently android projects use 3.3 wrapper version https://developer.android.com/studio/releases/gradle-plugin.html
  2. Also, i don't think that increasing heap size inside the plugin is a good idea. Plugin, itself don't need a lot of memory. And, it's just a plugin, it's not a standalone android project. If you need to increase heap size for your android project, you can do it directly for the project, but not for plugin.

@friederbluemle
Copy link
Author

Gradle 3.5 brings performance improvements. And as explained above, without the increase in heap space, dex will run out of process, slowing down the build, and generating the warning. It's also the default now.

@friederbluemle
Copy link
Author

friederbluemle commented Apr 19, 2017

Rebased onto latest master branch.

@friederbluemle friederbluemle changed the title Update Gradle wrapper to 3.5 Update Gradle wrapper to 4.0 Jul 6, 2017
@friederbluemle
Copy link
Author

Commit amended and updated to the latest stable version 4.0.
@smalichenko Do you have any other questions or concerns about this?

@friederbluemle
Copy link
Author

Updated again to latest stable version 4.0.1

@friederbluemle friederbluemle changed the title Update Gradle wrapper to 4.0 Update Gradle wrapper to 4.0.1 Jul 16, 2017
@friederbluemle
Copy link
Author

Updated again to latest stable version 4.1

@friederbluemle friederbluemle changed the title Update Gradle wrapper to 4.0.1 Update Gradle wrapper to 4.1 Aug 8, 2017
@friederbluemle friederbluemle force-pushed the update-gradle-wrapper branch 2 times, most recently from 8167b4b to 2efcc4a Compare October 9, 2017 04:53
@friederbluemle
Copy link
Author

Updated again to latest stable version 4.2.1 and rebased onto latest master branch.

@friederbluemle friederbluemle changed the title Update Gradle wrapper to 4.1 Update Gradle wrapper to 4.2.1 Oct 9, 2017
@friederbluemle
Copy link
Author

Updated again to latest stable version 4.3.1

@friederbluemle friederbluemle changed the title Update Gradle wrapper to 4.2.1 Update Gradle wrapper to 4.3.1 Nov 12, 2017
@friederbluemle
Copy link
Author

Updated again to latest stable version 4.6

@friederbluemle friederbluemle changed the title Update Gradle wrapper to 4.3.1 Update Gradle wrapper to 4.6 Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants