Skip to content
This repository has been archived by the owner on May 27, 2022. It is now read-only.

[serde-generate] fix empty struct/tuple variants in python and swift #122

Merged
merged 2 commits into from
Dec 3, 2021
Merged

[serde-generate] fix empty struct/tuple variants in python and swift #122

merged 2 commits into from
Dec 3, 2021

Conversation

ma2bd
Copy link
Contributor

@ma2bd ma2bd commented Dec 3, 2021

Summary

Support enum Foo { Bar(), Baz{} }

Test Plan

new test cases + CI

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 3, 2021
@ma2bd ma2bd requested a review from tzakian December 3, 2021 00:18
tzakian
tzakian approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@tzakian tzakian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@ma2bd ma2bd merged commit 0c7ad43 into novifinancial:main Dec 3, 2021
@ma2bd ma2bd deleted the serdegen_fix branch December 3, 2021 02:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tzakian tzakian tzakian approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ma2bd @tzakian @facebook-github-bot