Skip to content
This repository has been archived by the owner on May 27, 2022. It is now read-only.

Update binary serde #80

Merged
merged 1 commit into from
Dec 24, 2020
Merged

Update binary serde #80

merged 1 commit into from
Dec 24, 2020

Conversation

danprinz
Copy link
Contributor

Summary

  • Update typescript runtime to use util for TextEncoder/TextDecoder
  • Return null for Unit (instead of undefined)
  • Handle more than double space needed for a new byte array insert (ensureBufferWillHandleSize)

Test Plan

no change

@danprinz danprinz requested a review from ma2bd as a code owner December 21, 2020 13:20
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 21, 2020
@ma2bd
Copy link
Contributor

ma2bd commented Dec 21, 2020

@danprinz Can you rebase this PR? (and/or squash some commits: the github UI shows that the resulting changes are very small)

@danprinz
update typescript runtime to use util for TextEncoder/Decoder, return…
a90c8b8 
… null for Unit (instead of undefined), handle more than double space needed for a new byte array insert (ensureBufferWillHandleSize)
@ma2bd ma2bd merged commit 9064157 into novifinancial:master Dec 24, 2020
@ma2bd
Copy link
Contributor

ma2bd commented Dec 24, 2020

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ma2bd ma2bd Awaiting requested review from ma2bd

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danprinz @ma2bd @facebook-github-bot