Skip to content
This repository has been archived by the owner on May 27, 2022. It is now read-only.

[serde-generate] Add support for nested byte vectors #97

Closed
wants to merge 1 commit into from

Conversation

tzakian
Copy link
Contributor

@tzakian tzakian commented Aug 19, 2021

Summary

This PR adds support for serialization/deserialization of vector<vector<u8>> to the serde-generate runtimes for C#, Go, Java, and Python.

Test Plan

Added additional tests to make sure serialization and deserialization works.

@tzakian tzakian requested a review from ma2bd as a code owner August 19, 2021 18:50
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 19, 2021
@ma2bd
Copy link
Contributor

ma2bd commented Aug 20, 2021

@tzakian Why do we need this?

@tzakian
Copy link
Contributor Author

tzakian commented Aug 20, 2021

@MatBD In the process of adding support for vector<vector<u8>> arguments to the transaction-builder generator I ran into issues where the underlying runtime for the generated code in C#, Go, Java, and Python didn't have support for serializing/deserializing vector<vector<u8>> (/Vector<Bytes>) and I couldn't see anywhere where support for that type existed, so this PR is adding in support for that type to the serialization/deserialization runtimes.

@tzakian
Copy link
Contributor Author

tzakian commented Aug 23, 2021

After discussion I'm going to close this PR out in favor of the newtype approach.

@tzakian tzakian closed this Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants