Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an alt valid schema (role_arn & source_profile) to addProfile #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rmtuckerphx
Copy link
Contributor

Both schema are valid as so should be able to add a profile using the alt schema:

[dev-admin]
role_arn = arn:aws:iam::555555555:role/admin
source_profile = master-user

[master-user]
aws_access_key_id = a
aws_secret_access_key = b

@coveralls
Copy link

coveralls commented Jun 9, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling f2e0724 on rmtuckerphx:master into 1799b86 on novking:master.

@novking
Copy link
Owner

novking commented Jun 13, 2018

https://docs.aws.amazon.com/cli/latest/topic/config-vars.html#using-aws-iam-roles
i believe credentials only have aws tokens. the "role_arn" and "source_profile" belongs to config.

Copy link
Owner

@novking novking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmtuckerphx
Copy link
Contributor Author

Thank you for considering the pull request.

The Amazon docs seem to indicate that the role_arn and source_profile belong in the config file, but they definitely also work in the credentials file.

For my purpose (AWS CLI Configure extension for VS Code) I like supporting it in the credentials file so I built the extension from my modified fork.

Thanks for an awesome library. Makes Alexa development with ask-cli so much better!!

@novking novking dismissed their stale review July 30, 2018 22:56

Thank you for your pull request. However, according to AWS doc (https://docs.aws.amazon.com/cli/latest/topic/config-vars.html#the-shared-credentials-file), your alt schema is not really valid. since this lib is supporting ASK CLI, i would like to follow their rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants