Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two-step 'disconnect' option with custom message #1502

Open
tlcarpenter opened this issue Dec 18, 2020 · 6 comments
Open

two-step 'disconnect' option with custom message #1502

tlcarpenter opened this issue Dec 18, 2020 · 6 comments

Comments

@tlcarpenter
Copy link

tlcarpenter commented Dec 18, 2020

Is your feature request related to a problem? Please describe.
The request is related to a security issue I submitted to Apple. I'm wondering if there is a way to communicate privately via email, if necessary, about the issue.

Describe the solution you'd like
An option to display a custom message when noVNC's 'disconnect' button is clicked; the message would be displayed prior to noVNC actually being disconnected and would give the user the option to cancel the 'disconnect' action or to proceed with disconnecting.

Describe alternatives you've considered
Not aware of any.

Additional context

@samhed
Copy link
Member

samhed commented Dec 22, 2020

You'd like a confirmation popup when disconnecting? Why would this have to be custom? And what does it have to do with Apple?

@samhed samhed added the feature label Dec 22, 2020
@samhed
Copy link
Member

samhed commented Jan 15, 2021

I got the following response outside of github:

The custom aspect of what I'm requesting is just to have the ability to
specify the text of the notification in the popup; in my case I'd like
to say something like "Have you logged out of your account on the remote
system? Terminating the VNC connection without logging out of the remote
system may allow access to the remote system's console if you reconnect."

@CendioOssman
Copy link
Member

I'm not so sure about the ability to customize this. But a general message could be interesting.

One issue though is how to hide it for users that understand how this works. E.g. a "Don't show this again" check box. We don't currently have any mechanism for that.

@samhed
Copy link
Member

samhed commented Jan 29, 2021

Couldn't such a "don't show this again"-choice be saved alongside the rest of the UI settings in the web storage?

@CendioOssman
Copy link
Member

Yes, sorry. I got this confused with TigerVNC where we don't have as flexible storage. :)

@samhed samhed added this to the Future Features milestone Aug 26, 2021
@yatru
Copy link
Contributor

yatru commented Aug 31, 2021

In the same line, could be added an option to send some key combination to logout the remote user then you click "disconnect" being those key combinations configurable in the parameters, for example for windows & ubuntu (windows + L) to lock the user or (Ctrl+Alt+Del) to logout in ubuntu

yatru added a commit to yatru/noVNC that referenced this issue Sep 3, 2021
When parameter disconnect_message is set, it will show a message to confirm the disconection being its value the text on the confirm dialog.

This is related to the issue novnc#1502 "two-step 'disconnect' option with custom message novnc#1502"
yatru added a commit to yatru/noVNC that referenced this issue Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants