Add allowQEMUExtKeyEvent option, which allows the qemu keyboard exten…

[devicenull]

Add allowQEMUExtKeyEvent option, which allows the qemu keyboard extensions to be disabled. This is required for compatability with instances that are still running with a '-k' option on the command line.

Setting this to false would fix the issues reported in #666

[samhed]

This shouldn't be placed around the callback functions, place it a few lines up please

[samhed]

Could you add this for ui.js as well?

[samhed]

A few comments, otherwise it LGTM

[devicenull]

Updated

[berrange]

This kind of hack should NOT be needed. The Extended keyboard event message contains both the scancode and keysym. The keysym sent should be exactly the same as the keysym sent with the non-extended keyboard event message. If QEMU has a keymap set, it will then ignore the scancode and only use the keysym.

If this is not working, then it suggests that the keysym being included in the extended keyboard event message is somehow different from the keysym being sent in the non-extended keyboard event message.

This bit of code in core/rfb.js looks pretty suspect

    _handleKeyPress: function (keyevent) {
        if (this._view_only) { return; } // View only, skip keyboard, events

        var down = (keyevent.type == 'keydown');
        if (this._qemuExtKeyEventSupported) {
            var scancode = XtScancode[keyevent.code];
            if (scancode) {
                var keysym = keyevent.keysym;
                RFB.messages.QEMUExtendedKeyEvent(this._sock, keysym, down, scancode);
            } else {
                Util.Error('Unable to find a xt scancode for code = ' + keyevent.code);
            }
        } else {
            keysym = keyevent.keysym.keysym;
            RFB.messages.keyEvent(this._sock, keysym, down);
        }
    },

Notice that in the extended event scenario it is sending "keyevent.keysym" but in the non-extended scenario it is sending "keyevent.keysym.keysym". Surely those should both be keyevent.keysym.keysym

[DirectXMan12]

@berrange this would be a short-term fix until we can integrate the two bits of handling logic (as per #666 (comment)). If we don't get that long-term fix before 0.7.0, we should merge this (with a UI option).

[samhed]

@devicenull could you add a UI option for this?

[CendioOssman]

No longer needed as the bug in the keyboard code should now be fixed.