Work around broken Alt keyup in Firefox #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/input/keyboard.js
Outdated
| @@ -281,6 +282,25 @@ Keyboard.prototype = { | |||
| Log.Debug("<< Keyboard.allKeysUp"); | |||
| }, | |||
|
|
|||
| _checkAlt: function (e) { | |||
There was a problem hiding this comment.
please leave a comment here about why this is necessary (I see you go into more detail below, but a brief
// work around broken Alt key handling on FF for Windows (see below)would be good here too
samhed
approved these changes
Mar 12, 2018
Firefox no longer sends keyup events properly for the Alt keys. Try to sniff out the state of the Alt key by monitoring other events that include its state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox no longer sends keyup events properly for the Alt keys. Try to sniff out the state of the Alt key by monitoring other events that include its state.
Relevant Firefox bugs:
https://bugzilla.mozilla.org/show_bug.cgi?id=1335347
https://bugzilla.mozilla.org/show_bug.cgi?id=1435717