Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier for downstream to modify settings #1428

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Make it easier for downstream to modify settings #1428

wants to merge 4 commits into from

Commits on Jun 26, 2020

  1. Handle all settings via UI.getSetting() 

    Makes sure everything behaves the same way, even if there is no visible
UI for a settings.
    @CendioOssman
    CendioOssman committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    9ee2426 View commit details
    Browse the repository at this point in the history

  2. Merge UI startup in to a single routine 

    Makes it easier to see how things are connected.
    @CendioOssman
    CendioOssman committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    4fc5872 View commit details
    Browse the repository at this point in the history

  3. Handle disabling settings without label

    @CendioOssman
    CendioOssman committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    568c3b3 View commit details
    Browse the repository at this point in the history

  4. Make it easier for downstream to modify settings 

    Expose a simple and stable API to override default settings, and force
settings that users shouldn't be able to change.
    @CendioOssman
    CendioOssman committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    326e535 View commit details
    Browse the repository at this point in the history