Clipboard: handle multiple CR+LF

[syrykh]

In case copied from the remote server text contains multiple new-lines, only the first occurence of "\r\n" is properly replaced with '\n'. If the received text is then directly written to clipboard with navigator.clipboard.writeText(e.detail.text), empty lines will be duplicated on macOS.

This PR addresses this issue by replacing all the occurrences instead.

[CendioOssman]

Thanks! That's a bit embarrassing that it was overlooked. :)

[samhed]

Thank you for the fix.

Out of interest, I attempted — and failed — to see the practical effects of this. You mentioned “empty lines will be duplicated on macOS”, what are the steps for this to happen?

What I did:

On the remote (RHEL 9 with MATE), I created a text file with \r\n linebreaks:

echo -ne "1\r\n" >> myfile
echo -ne "2\r\n" >> myfile
echo -ne "3" >> myfile

I then connected using noVNC from Safari on macOS. I opened myfile in both Pluma and vim and both apps displayed the file as containing 3 rows as expected. After copying the contents I still see it as 3 rows, both in the clipboard textarea in Safari, and in macOS notes when pasted.

Note that I can verify, using Safari's developer tools, that I see the bug. The textData in my JavaScript event contains 1\n2\r\n3.

[syrykh]

Hi @samhed,

It seems that most of macOS apps convert "\r\n" to "\n" on the fly, so it's hard to spot. You can try Alacritty terminal emulator, where this issue is visible: if you do echo -e '1\n2\r\n3' | pbcopy in a standard terminal, then open vim in the alacritty and paste, you'll see this: