Adding support for unix sockets as target socket. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanaka
added a commit
that referenced
this pull request
May 30, 2012
Adding support for unix sockets as target socket.
kanaka
added a commit
that referenced
this pull request
May 31, 2012
- Rename unix socket option to '--unix-target' to be consistent with '--ssl-target' which is an analogous switch. - Fix normal socket target mode which was broken after merge. - Normalize/fix output for SSL, unix socket and wrap command modes.
|
There was some cleanup I had to do because the merge introduced some bugs. Also, I renamed --unix to --unix-target since the option is analogous to --ssl-target. Can you verify that the unix socket mode still works with the fixups I did? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you can test it using linuxvnc .. It's a tool inside vncterm directory in libvncserver that is used to remote your tty. Though you will have to use our own forked version of libvncserver [0]
Launch it as
./linuxvnc tty_num -unix /tmp/unix_socket
then launch websockify and use -unix /tmp/unix_socket instead of target_host:target_port
[0] https://github.com/cloud9ers/libvncserver