Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Migrate to AndroidX #36

Merged
merged 5 commits into from Feb 17, 2019
Merged

Migrate to AndroidX #36

merged 5 commits into from Feb 17, 2019

Conversation

ataulm
Copy link
Contributor

@ataulm ataulm commented Feb 17, 2019

This PR updates the library to use AndroidX dependencies. This means that we can update for bugfixes as they come out since changes aren't being shipped to the old support library anymore.

In terms of actual classes that changed, these are the only ones that are included in the library which have been migrated (apart from resource/nullability annotations):

  • AccessibilityDelegateCompat
  • AccessibilityNodeInfoCompat
  • AlertDialog

This will require a version bump since it won't be backwards compatible with projects that haven't migrated to AndroidX yet.

@hal9002
Copy link

hal9002 commented Feb 17, 2019

Can one of the admins review this PR?

@tasomaniac
Copy link
Contributor

Looks good

@mr-archano
Copy link
Contributor

The CI setup seems botched, I am about to look into that.
@ataulm what is the release process for this? It seems like no snapshot/automated releases are in place, right?

@ataulm
Copy link
Contributor Author

ataulm commented Feb 17, 2019

I don't remember 😬

I believe when we wanted to make a release, there we would do one more PR with a version bump, trigger the release job manually on the CI and then create a new release on GH listing the PRs included since the last release.

I don't think there's a rush with releasing - there's no new features or bug fixes since the last release, so maybe it can wait til something else changes.

Existing apps using this can use the old artifact as long as they have jetifier enabled (if they're using android X) or just the old artifact if they haven't migrated their app project to android x

@mr-archano
Copy link
Contributor

@hal90002 retest this please

@mr-archano mr-archano merged commit 7482205 into master Feb 17, 2019
@mr-archano mr-archano deleted the androidx branch February 17, 2019 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants