New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe / Add Native Ads Express #26
Conversation
You can better preview this doc here: https://github.com/novoda/android-demos/blob/963b36fff1344c09700db9e303724735c563be2c/Cookbook/add_native_express_adverts.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job @lgvalle
One minor remark: you could have used the description to highlight how this recipe is more useful than looking at the official doc/sample (if any), eg:
- it's more concise
- it lists also the pre/post steps for X
- there's a quirk with Y that is not mentioned anywhere
- ...
MobileAds.initialize(getApplicationContext(), getString(R.string.ad_app_id)); | ||
``` | ||
|
||
2. Load the view and build a request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed here 74dcf57
|
||
The process is the same as loading a regular ad: | ||
|
||
1. In the activity, initialise MobileAds: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put MobileAds
into backticks maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed here 5f81b00
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, just one little remark:
Please add an entry including a link to the README.md
Updated here 3da83b8 @tobiasheine |
You are right @mr-archano . I added a "Reasons to exist" block into the description. We can use the same approach in upcoming recipes. Is good to write down the reasons behind writing it |
Scope of the PR
Adds a recipe on how to create and integrate the newish Native Ads Express.
Reasons to exist
This cookbook tries to clarify that.