Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe / Add Native Ads Express #26

Merged
merged 4 commits into from Jan 18, 2017
Merged

Conversation

lgvalle
Copy link
Contributor

@lgvalle lgvalle commented Jan 12, 2017

Scope of the PR

Adds a recipe on how to create and integrate the newish Native Ads Express.

Reasons to exist

  • Having a single guide to walk you through the process of creating and Advert and integrating it is more useful than checking separate documentation for each task.
  • Google documentation is not very clear about advert sizes. At first sight it looks like the sizes you define when creating an Ad is the size you need to use later when integrating it.
    This cookbook tries to clarify that.

@lgvalle
Copy link
Contributor Author

lgvalle commented Jan 12, 2017

Copy link
Contributor

@mr-archano mr-archano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job @lgvalle
One minor remark: you could have used the description to highlight how this recipe is more useful than looking at the official doc/sample (if any), eg:

  • it's more concise
  • it lists also the pre/post steps for X
  • there's a quirk with Y that is not mentioned anywhere
  • ...

MobileAds.initialize(getApplicationContext(), getString(R.string.ad_app_id));
```

2. Load the view and build a request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still looks like 1. in the preview

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed here 74dcf57


The process is the same as loading a regular ad:

1. In the activity, initialise MobileAds:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put MobileAds into backticks maybe?

Copy link
Contributor Author

@lgvalle lgvalle Jan 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed here 5f81b00

Copy link
Contributor

@tobiasheine tobiasheine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, just one little remark:
Please add an entry including a link to the README.md

@lgvalle
Copy link
Contributor Author

lgvalle commented Jan 17, 2017

Updated here 3da83b8 @tobiasheine

@lgvalle
Copy link
Contributor Author

lgvalle commented Jan 17, 2017

You are right @mr-archano . I added a "Reasons to exist" block into the description. We can use the same approach in upcoming recipes. Is good to write down the reasons behind writing it

@tobiasheine tobiasheine merged commit 9e485c8 into master Jan 18, 2017
@tobiasheine tobiasheine deleted the recipe_native_ads_express branch January 18, 2017 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants