Test automation starter #44

dkaravias · 2018-06-26T09:46:33Z

Adding the whole app to master.
Worked with Sven.
The next PRs will be smaller and will reflect the work done for the Test automation guidelines

bartzet

Let's clean up those empty lines to be more consistent. Not only in the files I marked but it would be good to go through all of them again.

bartzet · 2018-06-26T13:52:20Z

AndroidTestAutomationStarter/README.md

+
+## Getting started
+
+Before launching the app you'll need to start the server. Make sure you have Ruby installed by running `ruby -v` from the terminal. If it's not installed run `brew install ruby`


Shall we also add the information on how to start the server or at least point to the website how to do that?

It's the next line, where it says Navigate to the simplesinatraapi directory in this project and run ruby server.rb . The directory is included in the project.

bartzet · 2018-06-26T13:57:50Z

...rter/app/src/androidTest/java/com/novoda/androidstoreexample/pageobjects/HeaderPageObject.kt

+    fun verifyHeader() {
+        HEADER.check(matches(isDisplayed()))
+    }
+


bartzet · 2018-06-26T13:58:51Z

...omationStarter/app/src/androidTest/java/com/novoda/androidstoreexample/EspressoHostModule.kt

+
+import com.novoda.androidstoreexample.dagger.module.HostModule
+
+


…efinitions

dkaravias · 2018-07-05T10:44:37Z

@bartzet I formatted the whole project with https://github.com/shyiko/ktlint
All Kotlin files should be consistent now.

fourlastor · 2018-07-06T14:38:15Z

...estAutomationStarter/app/src/androidTest/java/com/novoda/androidstoreexample/ViewMatchers.kt

+    fun withCategoryTitle(title: String): Matcher<RecyclerView.ViewHolder> {
+        return object : BoundedMatcher<RecyclerView.ViewHolder, CategoryAdapter.Holder>(CategoryAdapter.Holder::class.java) {
+            override fun matchesSafely(item: CategoryAdapter.Holder): Boolean {
+                if (item.categoryName != null) {


you can do return item.categoryName?.let { it.text.toString().equals(title, true) } ?: false

fourlastor · 2018-07-06T14:39:03Z

...estAutomationStarter/app/src/androidTest/java/com/novoda/androidstoreexample/ViewMatchers.kt

+            }
+
+            override fun describeTo(description: Description) {
+                description.appendText("view holder with title: " + title)


you can do "with title: $title"

fourlastor · 2018-07-06T14:39:55Z

...estAutomationStarter/app/src/androidTest/java/com/novoda/androidstoreexample/ViewMatchers.kt

+            }
+
+            override fun matchesSafely(item: ProductListAdapter.Holder?): Boolean {
+                if (item?.productName != null) {


you can use the let here (as before)

fourlastor · 2018-07-06T14:42:18Z

...pp/src/androidTest/java/com/novoda/androidstoreexample/pageobjects/MainActivityPageObject.kt

+    fun navigateToProductList() {
+        val categoryMatcher = ViewMatchers.withCategoryTitle("HATS")
+
+        onView(withId(R.id.categoryListView)).perform(actionOnHolderItem(categoryMatcher, click()))


I'd split this in 2 lines

fourlastor · 2018-07-06T14:43:51Z

...r/app/src/androidTest/java/com/novoda/androidstoreexample/tests/EspressoJavaTestExample.java

+import static android.support.test.espresso.matcher.ViewMatchers.isDisplayed;
+import static android.support.test.espresso.matcher.ViewMatchers.withId;
+
+@RunWith(AndroidJUnit4.class)


this isn't required anymore btw (doesn't do anything)

Nice, tbh the whole test is redundant by now but we can leave it to have a Java/Kotlin side by side example (also demonstrating the difference between using or not using page objects)

fourlastor · 2018-07-06T15:17:12Z

...omationStarter/app/src/main/java/com/novoda/androidstoreexample/services/CategoryResponse.kt

+import java.util.*
+
+data class CategoryResponse(val categories: Array<Category>) {
+    override fun equals(other: Any?): Boolean {


this is a data class, equals and hashCode are already implemented, unless you need a very specific behavior, I recommend removing both

I'd rather check with @thywen who wrote this

fourlastor · 2018-07-06T15:17:29Z

...tomationStarter/app/src/main/java/com/novoda/androidstoreexample/services/ProductResponse.kt

+import java.util.*
+
+data class ProductResponse(val products: Array<Product>) {
+    override fun equals(other: Any?): Boolean {


same here about equals/hashCode

same as above

fourlastor · 2018-07-06T15:18:55Z

AndroidTestAutomationStarter/simplesinatraapi/basket.rb

+
+  def add_to_basket(item)
+    item_id = item.id
+    p item_id


I think the print can be removed

fourlastor · 2018-07-06T15:21:30Z

AndroidTestAutomationStarter/simplesinatraapi/item_repository.rb

+  def initialize
+    @items = { '3': [
+        Item.new(1, 'Hat Green', '$18', 'hat1', get_random_description(4)),
+        Item.new(2, 'Hat Black', '$12', 'hat2', get_random_description),


I'd remove the default and pass 2 here, it's used as a default only once and it makes this look weird 😄

fourlastor · 2018-07-06T15:25:02Z

AndroidTestAutomationStarter/simplesinatraapi/item_repository.rb

+    Faker::Hipster.sentences(number_of_sentences).join(' ')
+  end
+
+  def get_item_for_id(id)


this looks more like a find_first_item_in_category(category_id)

also, if the category has zero items, you'll get an index out of bounds

Again, care to explain when you have some time?

fourlastor · 2018-07-10T08:43:16Z

...c/main/java/com/novoda/androidstoreexample/mvp/interactor/impl/CategoryListInteractorImpl.kt


    override fun loadCategoryList(categoryListListener: CategoryListListener) {
        call = apiService.getCategories()
-        call.enqueue(object : Callback<CategoryResponse> {
+        call?.enqueue(object : Callback<CategoryResponse> {
            override fun onResponse(call: Call<CategoryResponse>?, response: Response<CategoryResponse>?) {


I think you can remove the nullables also here

fourlastor · 2018-07-10T08:43:31Z

...rc/main/java/com/novoda/androidstoreexample/mvp/interactor/impl/ProductListInteractorImpl.kt


    override fun loadProductList(produListListener: ProductListListener, category: Int) {
        call = apiService.getProductsFromCategory(category)
-        call.enqueue(object : Callback<ProductResponse> {
+        call?.enqueue(object : Callback<ProductResponse> {
            override fun onFailure(call: Call<ProductResponse>?, t: Throwable?) {


and here (removing the nullables)

fourlastor · 2018-07-10T08:45:18Z

...utomationStarter/app/src/main/java/com/novoda/androidstoreexample/activities/MainActivity.kt

+    }
+
+    override fun onItemClicked(type: Int) {
+        intent = Intent(this, ProductListActivity::class.java).apply { putExtra(CATEGORY_ID_EXTRA, type) }


this is setting the activity intent ⚠️ be sure you use val

jgtaylor123 · 2018-07-11T09:57:49Z

Gave it a walk through, tests are running. Looks good.

jgtaylor123

👍 👍

dkaravias added 2 commits May 17, 2018 21:49

Added to Android Demos

f4ec208

README cleaning

aebd2b2

dkaravias requested review from jgtaylor123 and tom-novoda June 26, 2018 09:46

bartzet suggested changes Jun 26, 2018

View reviewed changes

dkaravias added 4 commits June 29, 2018 16:36

Updated README

4841f0f

Updated min SDK

9bd38a8

Removed Cucumber-related dependencies, Custom Test Runner, and Step D…

014061e

…efinitions

Run the ktlint formatter on the project

dcd75d5

bartzet approved these changes Jul 5, 2018

View reviewed changes

dkaravias added 2 commits July 5, 2018 15:40

Deleted wrongly configured simplesinatraapi directory

30711f7

Added the local server

00d4fdb

fourlastor self-requested a review July 6, 2018 15:06

fourlastor suggested changes Jul 6, 2018

View reviewed changes

dkaravias added 4 commits July 9, 2018 18:28

ViewMatchers cleaning up

a6abf1e

Removed obsolete @RunWith(AndroidJUnit4.class) from the Tests

6836161

Cleaning up

7ad5d75

Server cleaning up

309a3a7

fourlastor suggested changes Jul 10, 2018

View reviewed changes

dkaravias added 10 commits July 10, 2018 13:16

Remove import

f33e9d8

Remove app module

217b15b

Make NetworkTimeout @nAmed

700d476

make intent a property

4228a78

Remove unnecessary toString() implementation

5d603ce

Refactored the Interactor classes to better follow Kotlin syntax

5e2f7d4

Use primary constructor

1d14e36

File formatting

52a6235

Small typo

fc234ea

Made server repository more readable

b1a48a8

dkaravias added 2 commits July 10, 2018 14:32

Refactored ProductListInteractorImpl to better follow Kotlin syntax

7bd4780

Added missing ")"

b226bb6

dkaravias added the PT label Jul 10, 2018

fourlastor approved these changes Jul 10, 2018

View reviewed changes

jgtaylor123 approved these changes Jul 11, 2018

View reviewed changes

jgtaylor123 merged commit e5c0687 into master Jul 11, 2018

dkaravias deleted the test_automation_starter branch December 12, 2018 13:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test automation starter #44

Test automation starter #44

dkaravias commented Jun 26, 2018

bartzet left a comment •

edited

bartzet Jun 26, 2018

dkaravias Jun 27, 2018

bartzet Jun 26, 2018

bartzet Jun 26, 2018

dkaravias commented Jul 5, 2018

fourlastor Jul 6, 2018

fourlastor Jul 6, 2018

fourlastor Jul 6, 2018

fourlastor Jul 6, 2018

fourlastor Jul 6, 2018

dkaravias Jul 9, 2018

fourlastor Jul 6, 2018

dkaravias Jul 9, 2018

fourlastor Jul 6, 2018

dkaravias Jul 9, 2018

fourlastor Jul 6, 2018

fourlastor Jul 6, 2018

fourlastor Jul 6, 2018

dkaravias Jul 9, 2018

fourlastor Jul 10, 2018

fourlastor Jul 10, 2018

fourlastor Jul 10, 2018

jgtaylor123 commented Jul 11, 2018

jgtaylor123 left a comment


		## Getting started

		Before launching the app you'll need to start the server. Make sure you have Ruby installed by running `ruby -v` from the terminal. If it's not installed run `brew install ruby`


		import com.novoda.androidstoreexample.dagger.module.HostModule

Test automation starter #44

Test automation starter #44

Conversation

dkaravias commented Jun 26, 2018

bartzet left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dkaravias commented Jul 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jgtaylor123 commented Jul 11, 2018

jgtaylor123 left a comment

Choose a reason for hiding this comment

bartzet left a comment •

edited