New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user flows to test automation starter #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkaravias
reviewed
Sep 21, 2018
@@ -19,13 +19,13 @@ | |||
import static android.support.test.espresso.matcher.ViewMatchers.isDisplayed; | |||
import static android.support.test.espresso.matcher.ViewMatchers.withId; | |||
|
|||
public class EspressoJavaTestExample { | |||
public class EspressoJavaTestExampleWithoutFramework { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -19,7 +19,7 @@ import org.junit.Rule | |||
import org.junit.Test | |||
import java.io.InputStream | |||
|
|||
class MockServerTestExample { | |||
class EspressoTestExampleWithMockServer { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
val category = "HATS" | ||
val product = "hat white" | ||
|
||
productUserFlow { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 nice improvement !
dkaravias
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user flow pattern
The user flow pattern is a level of abstraction between the actual tests and the page objects. It is used to reduce the duplications of commonly used flows as well as the numbers of lines in the test methods to make them easier to understand.
This pr adds the usage of these User flows and the page object chaining to the framework. I also changed the method names of the checks to make the purpose clearer.