This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Installation errors should break the build #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasomaniac
commented
Jan 4, 2017
| @@ -70,6 +70,6 @@ class Device { | |||
| } | |||
|
|
|||
| String toString() { | |||
| getClass().name + [id: id, sdk: sdkVersion(), version: androidVersion(), brand: brand(), manufacturer: manufacturer(), model: model(), country: country(), language: language(), timezone: timezone()] | |||
| getClass().simpleName + [id: id, sdk: sdkVersion(), version: androidVersion(), brand: brand(), manufacturer: manufacturer(), model: model(), country: country(), language: language(), timezone: timezone()] | |||
There was a problem hiding this comment.
Also decided to use simpleName here. The name was too verbose. Now it just says Device which makes sense.
devisnik
approved these changes
Jan 4, 2017
| @Override | ||
| protected handleCommandOutput(def text) { | ||
| super.handleCommandOutput(text) | ||
| def matcher = text =~ /Failure \[(.*?)\]/ |
There was a problem hiding this comment.
Somewhat hacky, but fine with me as long at it fixes the behaviour.
There was a problem hiding this comment.
I know with Nougat release, Android team did a lot of refactoring in adb. I remember I listened in this podcast. They know forward exit code and error stream of the command being run on the device when we run adb shell.
Unfortunately adb install always succeeds with this message in it. I think I need to open a bug report about this.
There was a problem hiding this comment.
Here is the report to ⭐️
https://code.google.com/p/android/issues/detail?id=231464
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
The problem was that the build was marked as successful even when the installation failed.
This was bad for
installDevicetask. But it was even worse forrunbecause it runs the old version assuming that the installation was successful.Solution
Our plugin does not really handles errors. Also the
adbalmost always exits with success (code 0) and never writes into error stream.We should investigate and maybe even report back to Google places where we can make use of error codes.
But in this specific case (APK installation), it is feasible to look at the output.
Now, I am searching for
Failurein the text and break the build with the original failure error code. It looks like this:Fixes #46