This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Fix nougat install #110
Merged
Fix nougat install #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 11, 2017 10:14
Combining different arguments was not a documented feature. It might be working on some devices, it might be ignored on some devices. Now it throws exception on Nougat devices because Nougat has a complete new implementation for adb shell interaction.
florianmski
approved these changes
Jan 11, 2017
| @@ -12,7 +12,7 @@ class Install extends AdbTask { | |||
| if (getCustomFlags()) | |||
| arguments += getCustomFlags() | |||
|
|
|||
| arguments += ['-rd', apkPath] | |||
| arguments += ['-r', '-d', apkPath] | |||
devisnik
reviewed
Jan 11, 2017
| handleCommandOutput(command.execute().text) | ||
|
|
||
| Process process = command.execute() | ||
| if (process.waitFor() != 0) { |
There was a problem hiding this comment.
This is what you mention only works on Nougat? Would be good to add a comment about that then, imho.
There was a problem hiding this comment.
Exactly. But it doesn't change any backward compatibility because it was always 0 before.
There was a problem hiding this comment.
let me open a quick pr adding a comment 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install task is broken on Nougat devices.
Solution
Separate the arguments so that it works on Nougat devices.
Combining different arguments was not a documented feature. It might be working on some devices, it might be ignored on some devices. Now it throws exception on Nougat devices because Nougat has a complete new implementation for adb shell interaction.
Note: Unfortunately again, it was a silent fail. It was trying to run after install fail, when we use
runtasks.So I decided to include a code piece that I had on my stash. It checks the exit code and errors accordingly. This feature will only work on Nougat devices but still it is useful for Nougat users.
Here is the output on a failure:
This PR fixes #108