Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Removed quotes from input tasks #59

Merged
merged 1 commit into from
Feb 3, 2015
Merged

Removed quotes from input tasks #59

merged 1 commit into from
Feb 3, 2015

Conversation

emartynov
Copy link
Contributor

Sorry haven't written any tests. But unfortunately I still have issue with project import. Please review

@xrigau
Copy link
Contributor

xrigau commented Nov 27, 2014

Hi @emartynov

Thanks very much for your contribution, but could you please explain what is the problem and the solution you found please? this makes it much easier to review PRs for us. More about that here: https://github.com/novoda/novoda/blob/master/CONTRIBUTING.md

Thanks!

@emartynov
Copy link
Contributor Author

Hi @xrigau

I should mention issue #49. And this fix for it. But it maybe breaks normal emulators.

@xrigau
Copy link
Contributor

xrigau commented Nov 28, 2014

Thanks!

@devisnik
Copy link
Contributor

I think the initial intent of the quotation was to enable spaces in the text. This does not seem to work anyway though, so 👍

On a side note, spaces need to be replaced by %s.

@emartynov
Copy link
Contributor Author

I didn't think about normal text input. Usually with login you don't have spaces.

Replacing spaces with is easy contribution but I still have issues with project importing. And this stops me from investigation how to write tests for gradle tasks.

@blundell
Copy link
Contributor

whats up with project importing? Can you make a separate issue to discuss it

@emartynov
Copy link
Contributor Author

I did it here #50. And I still have it with AS and IDEA

@xrigau
Copy link
Contributor

xrigau commented Dec 1, 2014

@emartynov as a temporary solution you could delete the buildSrc folder, that should allow you import the project I think

@stefanhoth
Copy link
Contributor

@xrigau @devisnik What's the status here? Merge or close, please.

devisnik added a commit that referenced this pull request Feb 3, 2015
Removed quotes from input tasks
@devisnik devisnik merged commit 00d5ac7 into novoda:develop Feb 3, 2015
@emartynov
Copy link
Contributor Author

Could you push 1.3.1-SNAPSHOT to maven repository?

@xrigau
Copy link
Contributor

xrigau commented Feb 4, 2015

@devisnik could you release to jcenter? if you need help ping me 💃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants