-
Notifications
You must be signed in to change notification settings - Fork 37
Conversation
Refer to this link for build results (access rights to CI server needed): |
@@ -0,0 +1,20 @@ | |||
package com.novoda.gradle.command | |||
|
|||
class ActivityStack extends AdbTask { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, seems this task does not do anything by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, if we need access to the stack the AdbTask is not ideal as tried
to explain in the PR description
Am 13.07.2015 16:23 schrieb "Volker Leck" notifications@github.com:
In
gradle-android-command-plugin/src/main/groovy/com/novoda/gradle/command/ActivityStack.groovy
#85 (comment)
:@@ -0,0 +1,20 @@
+package com.novoda.gradle.command
+
+class ActivityStack extends AdbTask {Hmm, seems this task does not do anything by default.
—
Reply to this email directly or view it on GitHub
https://github.com/novoda/gradle-android-command-plugin/pull/85/files#r34467426
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry, did not read that carefully enough.
The base class approach to provide adb access might be something to rethink in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the task you define below could be the default behaviour here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devisnik moved dump to the task class.
Refer to this link for build results (access rights to CI server needed): |
Conflicts: sample/build.gradle
@devisnik Good to merge? |
👍 |
Feature/add task for Activity Stack
This PR adds an ActivityStack task and an new task to the sample dumping the activity stack.
The task is based on
AdbCommand
, however, it does not usesrunCommand
(and nothandleCommandOutput
as tried initially 6c3f45d) becauserunCommand
does not return anything and the would not have access to the activity stack.Now users can call
getActivityStack
and perform actions on the stack in their custom task.The default action is dumping the stack. The output looks like