This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Exclude kotlin files by default on java code quality tools. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins review this PR? |
|
hal test this please |
rock3r
previously approved these changes
Jul 4, 2018
mr-archano
approved these changes
Jul 4, 2018
mr-archano
suggested changes
Jul 4, 2018
There was a problem hiding this comment.
@tasomaniac could you please change the base branch for this? we usually bring features to develop and then ship from master
|
Oh good catch, totally missed that myself |
|
Aha! 💡Will do. |
tasomaniac
force-pushed
the
ignore-kotlin-in-java-tools
branch
from
4f657ce
to
ee34ef0
Compare
|
@mr-archano @rock3r please take another look :) |
|
CI please test this |
rock3r
approved these changes
Jul 9, 2018
mr-archano
approved these changes
Jul 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a default exclusion for kotlin files on Checkstyle, Findbugs and PMD tools.
Note: Since
sampleis in master, I couldn't change it to reflect these changes. That needs to be updated separately.Also update samples to remove redundant excludes.Also fixes the detekt config not to fail so that the plugin handles violations. This is already the recommended approach in our guides. Sample should reflect that.Fixes #56