This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Update docs for ktlint integration #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rock3r
reviewed
Aug 14, 2018
docs/tools/ktlint.md
Outdated
| For other configuration options and adding custom rules, refer to the | ||
| [official guide](https://github.com/JLLeitschuh/ktlint-gradle/#configuration). | ||
|
|
||
| **Note:** Please make sure __note__ to set `ignoreFailures = false` since failures and threshold detection is handled by |
There was a problem hiding this comment.
I think that __note__ in the middle is a leftover of something else, and to double check: I would expect ignoreFailures to be set to true because we don't want ktlint to break the build itself
There was a problem hiding this comment.
I will update. We already automatically set it to true. Here I was trying to say that they shouldn't set it to false.
There was a problem hiding this comment.
Actually, note should be not here.
But I will reword this. It is too many negates. Also because of ignoreFailures. ktlint could've chosen a positive prop here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.