This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Fix some ktlint issues #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #140 |
|
Also fixes #129 since I use |
mr-archano
reviewed
Nov 8, 2018
plugin/src/main/groovy/com/novoda/staticanalysis/internal/ktlint/KtlintConfigurator.groovy
Show resolved
Hide resolved
plugin/src/test/groovy/com/novoda/staticanalysis/internal/ktlint/KtlintIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
Fix 6.x versions only for pure Kotlin projects
tasomaniac
force-pushed
the
taso/fix/ktlint
branch
from
2aca566
to
c33727e
Compare
tasomaniac
commented
Nov 8, 2018
| @@ -26,7 +26,6 @@ apply plugin: 'kotlin-android' | |||
|
|
|||
| android { | |||
| compileSdkVersion 27 | |||
| buildToolsVersion '27.0.0' | |||
There was a problem hiding this comment.
These were giving warnings. Not really needed.
This was referenced Nov 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to fix some ktlint issues.
CHECKSTYLEreporter since passing String is not supported anymore and we cannot really reference their enum type in our integration.CHECKSTYLEin their config.Problems:
ktlintChecktask giveNO-SOURCEno matter I tried. Will spend some more time later.