This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Make Findbugs Html report optional #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasomaniac
commented
Dec 5, 2018
| pmdExtension.toolVersion = '5.5.1' | ||
| pmdExtension.rulePriority = 5 | ||
| } | ||
| return { extension -> |
There was a problem hiding this comment.
Also did this on other tools as a boy-scouting. Looks nicer.
mr-archano
previously approved these changes
Dec 6, 2018
|
@hal90002 retest this please |
|
Looks like one test is getting NPE. |
mr-archano
previously approved these changes
Dec 7, 2018
mr-archano
suggested changes
Dec 7, 2018
There was a problem hiding this comment.
@tasomaniac isn't the base branch supposed to be develop instead?
|
Just updated it 😄Let's see what CI says now :) Btw, I did couple of commits and reverts. Feel free to squash and merge. |
mr-archano
approved these changes
Dec 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
htmlReportEnabledto the DSL to control whether we should generate html report or not.Initially I wanted to use
reports.html.enabledbut that is not available.FindbugsExtensionis pretty limited and unfortunately does not have that built-in. It is inFindbugstask and to be able to use that we would require users to use something liketasks.withType(Findbugs) { reports.html.enabled = false }which is ugly.Fixes #117