This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
PT-420: Honour Android variants in Chesktyle and PMD #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasomaniac
reviewed
Jan 27, 2017
| variant.sourceSets.each { sourceSet -> | ||
| def taskName = "pmd${sourceSet.name.capitalize()}" | ||
| Pmd pmd = tasks.findByName(taskName) | ||
| if (pmd == null) { |
There was a problem hiding this comment.
I like the null check. If I understood it right, this ensures that it is created only once.
tasomaniac
approved these changes
Jan 27, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of the PR
During the integration of this plugin in one of our running projects @xrigau noticed that all Checkstyle and PMD tasks were run even tho some of the variants were disabled. The root issue is in the way we are creating such tasks, where only the source sets are evaluated without actually considering the variants.
Considerations and implementation
TestProjectbuildersApplicationVariant/TestVariant/UnitTestVariantto determine which source sets should be inspected by Checkstyle and PMD.main) we ensure only oneCheckstyleMain/PmdMaintask is createdTest(s) added
Added integration tests checking behaviour of Checkstyle and PMD wrt Android variants. Scenarios include:
variantFileter)Paired with
@ 👻